Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified code to incorporate changes made in NDO version >= 4.2's API response for 'regions' #254

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Modified code to incorporate changes made in NDO version >= 4.2's API response for 'regions' #254

merged 4 commits into from
Nov 27, 2023

Conversation

shrsr
Copy link
Collaborator

@shrsr shrsr commented Nov 21, 2023

No description provided.

@shrsr shrsr self-assigned this Nov 21, 2023
@shrsr shrsr linked an issue Nov 21, 2023 that may be closed by this pull request
Getting "Plugin did not respond" messages with 0.10.0 and later #253
Closed
@shrsr
[bugfix] Modified code in datasource 'mso_schema_site_vrf_region' to …
8792a34 
…incorporate changes made in NDO version >= 4.2's API response for 'regions'
akinross
akinross previously approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr shrsr linked an issue Nov 23, 2023 that may be closed by this pull request
Plugin error for NDO v4.2 when using AWS sites in 'mso_tenant' for both resource and data source #255
Closed
@shrsr shrsr requested a review from akinross November 23, 2023 23:02
sajagana
sajagana previously approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current change looks good! but resource required additional fix to handle idempotent check.

akinross
akinross previously approved these changes Nov 24, 2023
View reviewed changes
@shrsr
[ignore] Work around to fix the computed hub_network from being added…
bb73bb6 
… upon second TF apply when it's empty in both config and the state
@shrsr shrsr dismissed stale reviews from akinross and sajagana via bb73bb6 November 24, 2023 16:36
@shrsr shrsr requested review from sajagana and akinross November 24, 2023 16:37
sajagana
sajagana approved these changes Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lhercot
lhercot approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 91b293c into CiscoDevNet:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajagana sajagana sajagana approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@akinross akinross akinross approved these changes

@lhercot lhercot lhercot approved these changes

@samiib samiib Awaiting requested review from samiib samiib is a code owner

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

Assignees

@shrsr shrsr

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@shrsr @lhercot @akinross @anvitha-jain @sajagana