Configure https.globalAgent to use systems root certs #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonvena
force-pushed
the
fix/node4-invalid-cert
branch
from
4ddd3ab
to
6155678
Compare
joonvena
changed the title
|
Looks good enough to me. As mentioned above this is supposed to be only a temporary workaround. See nodejs/node#4175 for further reference. |
|
This is now obsolete as the Node version was upgraded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current Node version used in the project root certificate that the Node uses has expired. This certificate is baked inside the Node's binary so you can't directly tell the Node itself to use certificates from other path. This change allows the application to configure the root certificate path. This is only temporary solution and more permanent solution would be to upgrade Node to newer version.