-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup webpack for development and production build #25
Conversation
Also, @kwheelan this is going to break github pages deployment. I'm not sure how gh-pages is setup on this repo since I don't have permission to check the settings, but if its setup to publish from the |
@maxatdetroit Thank you for setting this up!
I think this issue is because I had the 'upload' page read in an excel file on my local machine that isn't in the repo (because it's real city data). #27 should fix this problem by enabling the file upload, so I'll review and merge that branch into
I've been using the 'Live Server' extension in VSCode to avoid the CORS issue. |
Thanks for flagging; I'll adjust the source folder when I merge this. |
Sounds good :) And thanks for the info on Live Server (TIL!). I'll wait til #27 is merged in then rebase & test on dev and this branch to make sure nothing is broken. Thanks, Katrina! |
Thanks! Just merged #27 |
@kwheelan I've merged in the latest excel upload/download features into this PR/branch. Testing works well now (see the workflow I followed in the initial comment at the top that was edited). Let me know if you want me to test anything else, otherwise it should be ready to merge. Also, I made notes about this in the After this PR, the development process is going to change a bit. Instead of using Live Server on the (1) (Preferred) Use webpack development server by running (1) Use Live Server on |
@maxatdetroit Thank you! |
Fixes #24
This PR introduces webpack which is used to both (1) host a local web server to serve the app during development with hot reload on edit and (2) create a production bundle of HTML, JS, and CSS for hosting in production environment where performance and file size are critical.
Specific things done in this PR:
src
directory to make space for a build director and make webpack config simplerTesting
I tested locally. I was able to go through the excel upload, modify the budget, download the excel file workflow and see the modified budget info in the downloaded excel file.
2024-07-17.12-57-05.mp4