Added need_additional_details column to Reasons table #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 25e093a into 0967097 - view on LGTM.com new alerts:
|
|
Ridhdhi is currently doing QA on this PR. |
joelbcastillo
approved these changes
Apr 27, 2021
|
This pull request introduces 1 alert when merging b66b12f into 0967097 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a column to the Reasons table for
need_additional_details. If this is set to true then an alert will pop up to prompt the user to provide additional details when selecting that reason for Denials and Closings. Also removes the census reminder alert from the codebase.Setup:
flask db migrateto upgrade database migrationupdate reasons set need_additional_details = false;to set default value for new columnupdate reasons set need_additional_details = true where id in (3, 35, 80);to set the reasons you want to trigger the alert. Currently set for "Fulfilled in Part", "Denied - Reason Below", "Denied in Part – Not All Records are Available"