Moving different transaction types to subclasses, adding transaction attribute class #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I saw that there were some notes in the code about refactoring the transaction reading and type system, so I did a bit of work on it. Including:
Transaction#read
method, moving all of the different logic to proper methods on the subclassesTransaction::Attribute
class to properly model transaction attributesNote that in making all of the transaction types into subclasses, I removed the
Transaction#type
method. It should be easy to add that to each of the subclasses if we need to preserve the backwards compatibility here---just let me know if that's the case and I'll add to this PR.Thanks, and I'm looking forward to helping out more with this library!