Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal PA Onboarding Materials #1284

Closed
wants to merge 30 commits into from
Closed

Drupal PA Onboarding Materials #1284

wants to merge 30 commits into from

Conversation

timozura
Copy link
Contributor

@timozura timozura commented Sep 20, 2023

Building out materials for Drupal onboarding OKR.


📚 Documentation preview 📚: https://civicactions-handbook--1284.org.readthedocs.build/en/1284/

Adding page 'Drupal for everyone'.
Creating Drupal for Project Teams page
Creating Drupal for Engineers page
Create Drupal for Drupal Engineers page.
Adding Drupal Glossary Page
…md to practice-areas/engineering/drupal/onboarding-materials/drupal-for-drupal-engineers.md
…ractice-areas/engineering/drupal/onboarding-materials/drupal-for-engineers.md
…actice-areas/engineering/drupal/onboarding-materials/drupal-for-everyone.md
…to practice-areas/engineering/drupal/onboarding-materials/drupal-for-project-teams.md
…ce-areas/engineering/drupal/onboarding-materials/drupal-glossary.md
@timozura timozura requested a review from a team as a code owner September 20, 2023 20:51
@timozura timozura changed the title Timozura patch 1 Drupal PA Onboarding Materials Sep 20, 2023
Copy link
Collaborator

@dmundra dmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @timozura, thank you for working on this. I like what is shaping up here.

I am not sure if this was in your plans, but there is some content overlap with this page https://guidebook.civicactions.com/en/latest/practice-areas/engineering/drupal/ and that page could be modified to link to your new pages to reduce the redundancy if desired.

Another item is take a look at https://guidebook.civicactions.com/en/latest/about-this-guidebook/editing-the-guidebook/#step-6-update-the-navigation to add the new pages to the navigation. It is right now a manual step that needs to happen.

Looks like there are a few failing remark lint checks, most of them are suggestions except these two:

  • Looks like instead of using a single quote you have to use a double quote in various places. Can that be changed?
  • The check does not like [site stats]. Maybe that can be dropped as well?

Let me know if I can help answer any questions about the checks or process to update the guidebook.


If you are contributing to drupal.org issues for CivicActions and our customers, please make sure to click the box under 'Attribute this contribution'. An example screenshot of what the checkbox looks like:

![attribute organization](/assets/images/drupal-pa/do-attribute-contribution.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image links needs to be setup to navigate to the folder. For an example, checkout the source of https://guidebook.civicactions.com/en/latest/practice-areas/engineering/drupal/.

@timozura
Copy link
Contributor Author

Closing this PR. I've gone and created my own fork and will be working from there. Makes things easier.

@timozura timozura closed this Sep 21, 2023
@dmundra dmundra deleted the timozura-patch-1 branch February 7, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants