Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal PA Onboarding pages. #1286

Merged
merged 14 commits into from
Sep 22, 2023
Merged

Drupal PA Onboarding pages. #1286

merged 14 commits into from
Sep 22, 2023

Conversation

timozura
Copy link
Contributor

@timozura timozura commented Sep 21, 2023

@timozura timozura requested a review from a team as a code owner September 21, 2023 20:52
@github-actions
Copy link
Contributor

Potential file addition - missing nav update

  • There appear to be new files added in this pull request, but the mkdocs.yml nav has not been modified.
  • If pages were added, please edit mkdocs.yml to add the new page to the menu.
  • If not, feel free to ignore this message.

@timozura timozura marked this pull request as draft September 22, 2023 18:08
@timozura timozura marked this pull request as ready for review September 22, 2023 20:15
@timozura timozura requested review from a team as code owners September 22, 2023 20:15
@timozura timozura changed the title Drupal PA Onboarding; Drupal for Everyone page. Drupal PA Onboarding pages. Sep 22, 2023
@@ -9,6 +9,7 @@ repos:
entry: civicactions/guidebook-lint:latest remark.sh
always_run: true
pass_filenames: false
verbose: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grugnog any issue with enabling verbose for these checks that you can see?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh..I updated that because I wanted to see the suggestions on commit. They were only showing if there was also an error. I can remove it, but it was helpful for me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fair. I am just not sure if our checks would care so I was curious. We can keep it and try it out.

Copy link
Collaborator

@dmundra dmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @timozura. Approved and noted that others can are going to work on editing the pages.

@timozura timozura merged commit de4c207 into master Sep 22, 2023
8 of 9 checks passed
@timozura timozura deleted the drupal_onboarding branch September 22, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants