Skip to content

Commit

Permalink
selftests/cgroup: fix uninitialized variables in test_zswap.c
Browse files Browse the repository at this point in the history
First of all, in order to build with clang at all, one must first apply
Valentin Obst's build fix for LLVM [1]. Once that is done, then when
building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...clang finds and warning about some uninitialized variables. Fix these
by initializing them.

[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
johnhubbard authored and htejun committed May 3, 2024
1 parent 3309ca6 commit 8f6d24a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/testing/selftests/cgroup/test_zswap.c
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ static int test_no_invasive_cgroup_shrink(const char *root)
{
int ret = KSFT_FAIL;
size_t control_allocation_size = MB(10);
char *control_allocation, *wb_group = NULL, *control_group = NULL;
char *control_allocation = NULL, *wb_group = NULL, *control_group = NULL;

wb_group = setup_test_group_1M(root, "per_memcg_wb_test1");
if (!wb_group)
Expand Down Expand Up @@ -342,7 +342,7 @@ static int test_no_kmem_bypass(const char *root)
struct sysinfo sys_info;
int ret = KSFT_FAIL;
int child_status;
char *test_group;
char *test_group = NULL;
pid_t child_pid;

/* Read sys info and compute test values accordingly */
Expand Down

0 comments on commit 8f6d24a

Please sign in to comment.