Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated methods to match docs #14

Merged
merged 43 commits into from
Jul 2, 2024
Merged

Conversation

DaniAkash
Copy link
Contributor

This pull request introduces several changes to the project, primarily focusing on the src/client/model.ts file and the test suite. The changes include the addition of a new dependency, modifications to the Dataset and Model classes, a change to the default search metric, and the addition of new test cases.

Dependency Changes:

  • package.json: Added axios as a new dependency to the project.

Modifications to Classes:

  • src/client/dataset.ts: Made the labels parameter optional in the Dataset class.
  • src/client/model.ts: Made several changes to the Model class, including modifying the BaseModelConfig and ModelConfigWithModelId interfaces to allow for modelUserAppId, and adding new conditions and error handling for url and modelUserAppId. The Model class constructor was also updated to handle authConfigFromUrl and modelUserAppId differently. [1] [2] [3]

Search Metric Change:

Test Suite Improvements:

@DaniAkash DaniAkash requested a review from brockdusome June 24, 2024 11:19
@DaniAkash DaniAkash changed the base branch from dani/rag to main June 28, 2024 13:52
@DaniAkash DaniAkash merged commit 3d46b72 into main Jul 2, 2024
3 of 5 checks passed
@DaniAkash DaniAkash deleted the dani/docs-example-update branch July 2, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants