-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated methods to match docs #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the project, primarily focusing on the
src/client/model.ts
file and the test suite. The changes include the addition of a new dependency, modifications to theDataset
andModel
classes, a change to the default search metric, and the addition of new test cases.Dependency Changes:
package.json
: Addedaxios
as a new dependency to the project.Modifications to Classes:
src/client/dataset.ts
: Made thelabels
parameter optional in theDataset
class.src/client/model.ts
: Made several changes to theModel
class, including modifying theBaseModelConfig
andModelConfigWithModelId
interfaces to allow formodelUserAppId
, and adding new conditions and error handling forurl
andmodelUserAppId
. TheModel
class constructor was also updated to handleauthConfigFromUrl
andmodelUserAppId
differently. [1] [2] [3]Search Metric Change:
src/constants/search.ts
: Changed the default search metric fromcosine
toeuclidean
.Test Suite Improvements:
tests/client/model.integration.test.ts
: Added several new test cases to the model integration test suite.tests/client/rag.integration.test.ts
: Increased the timeout for a test case in the Rag integration test suite.