-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RAG Module #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of the type changes I mentioned would make this code much easier to understand as well as maintain.
I'd also like to see some examples for this stuff, because then I could look and see how I'm expected to consume these classes/methods as an end-user. This also makes it easier for us to see if we're creating something that's easy to use.
The examples have been published in https://docs.clarifai.com/sdk/rag |
Feedback was addressed, secondary approval acquired, removing to unblock merging.
This pull request includes multiple changes to the codebase, primarily focused on enhancing the functionality of the
App
,Model
, andWorkflow
classes, updating thepackage.json
dependencies, and introducing a new constant in therag.ts
file.The changes can be grouped into four main categories:
Dependency updates: Two new dependencies were added to the
package.json
file. These include@types/tmp
andllamaindex
. [1] [2]App class enhancements: Several changes were made to the
App
class in theapp.ts
file. Notably, theAppConfig
type was updated, and a newUserAppIDSet
was imported and used within the class. TheApp
class now includes a newinfo
property, and several methods were updated to include amodelUserAppId
parameter. [1] [2] [3] [4] [5] [6] [7] [8]Model class enhancements: The
Model
class in themodel.ts
file underwent several changes. TheModelConfig
type was updated and a newUserAppIDSet
was imported and used within the class. TheModel
class now includes a newmodelUserAppId
property, and several methods were updated to include amodelUserAppId
parameter. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Workflow class and other enhancements: The
Workflow
class in theworkflow.ts
file was updated to include newid
andappId
properties. A new constantMAX_UPLOAD_BATCH_SIZE
was added to therag.ts
file, and therag
module was exported in theindex.ts
file. [1] [2] [3] [4]