Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale handling #18

Open
nylen opened this issue Oct 22, 2018 · 1 comment
Open

Locale handling #18

nylen opened this issue Oct 22, 2018 · 1 comment

Comments

@nylen
Copy link
Contributor

nylen commented Oct 22, 2018

We don't have locale-specific builds of ClassicPress yet, so all migration will need to happen using the default en_US build until those are ready.

I tested the migration process using an es_ES install (code added to support this in 68e57ca). It worked, but after the migration, the site's locale was set back to English.

I changed it to Spanish, and most strings were still translated. As expected, though, ClassicPress-specific strings were left in English:

2018-10-22t16 43 41-05 00

2018-10-22t16 44 02-05 00

Potential action items here, in order from easiest to hardest:

  • Add a warning indicating that the site's locale will be switched back to English after the migration.
  • Figure out why the site's locale is switched back to English, and prevent this from happening.
  • Release localized builds of ClassicPress and use them in the plugin.
@nylen
Copy link
Contributor Author

nylen commented Jan 29, 2019

See ClassicPress/ClassicPress-v1#154:

It's probably best to address the overarching issue with this: #18 on the migrate plugin. Maybe a yellow caution icon and warning letting them know their current locale isn't supported yet?

When we migrate a WP site from a language that ClassicPress doesn't support yet (i.e. not listed in our translations API endpoint) then we should show a warning message.

Also need to test & make sure that WP language packs get correctly updated/refreshed to the latest ClassicPress languages during the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant