fix(temperature): end parser

ClaudiuCeia · Jul 22, 2022 · 3482064 · 3482064
1 parent b384957
commit 3482064
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/src/Temperature.ts b/src/Temperature.ts
@@ -12,7 +12,7 @@ import {
   space,
   skip1,
 } from "combine/mod.ts";
-import { EntityLanguage, __ } from "./common.ts";
+import { EntityLanguage, __, dot } from "./common.ts";
 import { ent, Entity } from "./Entity.ts";
 import { Quantity, QuantityEntity } from "./Quantity.ts";
 
@@ -122,5 +122,5 @@ export const Temperature = createLanguage<TemperatureEntityLanguage>({
           a
         )
     ),
-  parser: (s) => any(s.BelowZero, s.Celsius, s.Fahrenheit, s.Unspecified),
+  parser: (s) => dot(any(s.BelowZero, s.Celsius, s.Fahrenheit, s.Unspecified)),
 });
diff --git a/tests/Temperature.test.ts b/tests/Temperature.test.ts
@@ -128,3 +128,26 @@ Deno.test("below zero", () => {
     ]);
   }
 });
+
+Deno.test("No false positive for temperature", () => {
+  const res = Duckling().extract({
+    text: `In 1837 Charles Babbage first described his Analytical Engine`,
+    index: 0,
+  });
+
+  assertEquals(res.success, true);
+
+  if (res.success) {
+    assertEquals(res.value, [
+      {
+        end: 7,
+        kind: "quantity",
+        start: 3,
+        text: "1837",
+        value: {
+          amount: 1837,
+        },
+      },
+    ]);
+  }
+});