Fix UI close crash #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im not really happy with how it is right now and the solution. Itll work as a temporary fix, but this needs to be reworked. |
brachy84
approved these changes
Dec 11, 2023
miozune
pushed a commit
to GTNewHorizons/ModularUI2
that referenced
this pull request
Jan 31, 2024
(cherry picked from commit 35104c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUI schedules UIs for opening 1 tick later (I'm not 100% sure on the reason for this, but I figure its important).
However, closing UIs 1 tick later causes the MUI panel state to be set as inactive/invalid before the window closes (in some cases, I'll explain below). Now we immediately close the UI, or pop the queued UI off the queue if there is one.
This seemed like a race condition or similar with the UI close animation because if that animation caused the panel to cross over into another tick (i.e., the
escinput is inputted in tick 50, but the animation ends in tick 51) then the crash would not occur.