Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Prevent mowing motor from starting and stopping repeatedly if GPS fix is lost. #125

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix: Prevent mowing motor from starting and stopping repeatedly if GPS fix is lost. #125

merged 1 commit into from
Jul 23, 2024

Conversation

olliewalsh
Copy link
Collaborator

No description provided.

@ClemensElflein ClemensElflein changed the title Fix setMowerEnabled logic Fix: Prevent mowing motor from starting and stopping repeatedly if GPS fix is lost. Jul 23, 2024
@ClemensElflein ClemensElflein marked this pull request as ready for review July 23, 2024 21:50
@ClemensElflein ClemensElflein added the bug Something isn't working label Jul 23, 2024
@ClemensElflein ClemensElflein merged commit 3db8023 into ClemensElflein:main Jul 23, 2024
1 of 4 checks passed
olliewalsh added a commit to olliewalsh/Mowgli that referenced this pull request Jul 23, 2024
@olliewalsh
Add mow_enabled to status message
dc35b50 
Update status msg and replicate mower_comms logic from
ClemensElflein/open_mower_ros#125
@olliewalsh olliewalsh mentioned this pull request Jul 23, 2024
Merged
olliewalsh added a commit to olliewalsh/Mowgli that referenced this pull request Jul 23, 2024
@olliewalsh
Add mow_enabled to status message
105352c 
Update status msg and replicate mower_comms logic from
ClemensElflein/open_mower_ros#125
@fallingcats
Copy link

This should be resolved in the latest releases-edge build, right? Because I don't think it is, it still does the spin-up thing every couple of seconds.

@fallingcats
Copy link

This should be resolved in the latest releases-edge build, right? Because I don't think it is, it still does the spin-up thing every couple of seconds.

I retract my earlier statement, I was sure I heard it, but don't think it does the thing anymore. MQTT data seems to confirm that.

@ClemensElflein
Copy link
Owner

thank you for reporting back! I'm glad it's fixed

@fallingcats
Copy link

Sorry, it still isn't fixed. It just also coincided with another bug where some things apparently aren't updated while "PAUSED". That includes battery % and now motor current apparently. Voltage still updates though.

@olliewalsh
Copy link
Collaborator Author

Sorry, it still isn't fixed. It just also coincided with another bug where some things apparently aren't updated while "PAUSED". That includes battery % and now motor current apparently. Voltage still updates though.

How are you testing? If it's using manual mowing in openmower-gui that will no longer work (it never should have, relied on this bug).
Battery % will not be updated if gps is timing out, will look into fixing that one. I expect you're mistaken about motor current.

@fallingcats
Copy link

Sorry, it still isn't fixed. It just also coincided with another bug where some things apparently aren't updated while "PAUSED". That includes battery % and now motor current apparently. Voltage still updates though.

How are you testing? If it's using manual mowing in openmower-gui that will no longer work (it never should have, relied on this bug). Battery % will not be updated if gps is timing out, will look into fixing that one. I expect you're mistaken about motor current.

I might have been trying to use manual mowing, but I could hear the motor try to spin up and stop, while not seeing any current in Home Assistant. I don't know where in the pipe the updates are stuck, but can't see them like I could before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olliewalsh @fallingcats @ClemensElflein