Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with Rust 1.80.0 #1500

Closed
1 task done
bowlofeggs opened this issue Jul 26, 2024 · 4 comments · Fixed by #1505
Closed
1 task done

Build failure with Rust 1.80.0 #1500

bowlofeggs opened this issue Jul 26, 2024 · 4 comments · Fixed by #1505
Labels
bug Something isn't working the way that is expected.

Comments

@bowlofeggs
Copy link
Contributor

Checklist

What operating system and version are you using?

Gentoo Linux

What architecture are you using?

x86_64/AMD64

What terminal(s) are you running bottom on that are experiencing the problem?

No response

What filesystem(s) are you using?

Btrfs

What version of bottom are you running?

0.9.6

How did you install bottom?

It will fail if installed with Gentoo (which builds it), or when using cargo build with Rust 1.80.0.

Describe the issue

Bottom uses an older version of time, which leads to a build failure with Rust 1.80.0.

What is the expected behaviour?

It should build successfully.

What is the actual behaviour?

error[E0282]: type annotations needed for `Box<_>`                                                                                                                                                                                                                     23:37:42 [492/1289]
  --> /var/tmp/portage/sys-process/bottom-0.9.6/work/cargo_home/gentoo/time-0.3.27/src/format_description/parse/mod.rs:83:9
   |                                                                  
83 |     let items = format_items                                                                                                                                                                                                                                                         
   |         ^^^^^                                                                                                                                                                                                                                                                        
...                                                                                                                                                                                                                                                                                       
86 |     Ok(items.into())                                                                                                                                                                                                                                                                 
   |              ---- type must be known at this point                                                                                                                                                                                                                                   
   |                                                                                                                                                                                                                                                                                      
help: consider giving `items` an explicit type, where the placeholders `_` are specified                                                     
   |                                                                                                                                         
83 |     let items: Box<_> = format_items                                                                                                    
   |              ++++++++                                                                                                                   
                                                                                                                                             
For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error

How can we reproduce this?

Build bottom with Rust 1.80.0.

Additional information

No response

@bowlofeggs bowlofeggs added the bug Something isn't working the way that is expected. label Jul 26, 2024
bowlofeggs added a commit to bowlofeggs/bottom that referenced this issue Jul 26, 2024
Time 0.3.27 fails to build with Rust 1.80.0, released today[0]. This
updates time to 0.3.36, which successfully builds with Rust 1.80.0.

[0] rust-lang/rust#127343

Fixes ClementTsang#1500

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
@bowlofeggs
Copy link
Contributor Author

It looks like this is fixed on main, so we just need a release to get it fixed for end users who cargo install.

@bowlofeggs
Copy link
Contributor Author

See rust-lang/rust#127343

bowlofeggs added a commit to bowlofeggs/gentoo that referenced this issue Jul 26, 2024
The version of time that bottom 0.9.6 uses does not build with Rust
1.80.0[0][1]. This bumps time to 0.3.36 to address the issue.

[0] ClementTsang/bottom#1500
[1] rust-lang/rust#127343

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
@ClementTsang
Copy link
Owner

Darn, was hoping I wouldn't be affected by this, but thanks for the heads up. I'll do a release in a bit, I'll probably just cherry-pick the change from main as needed.

bowlofeggs added a commit to bowlofeggs/gentoo that referenced this issue Jul 26, 2024
The version of time that bottom 0.9.6 uses does not build with Rust
1.80.0[0][1]. This bumps time to 0.3.36 to address the issue.

[0] ClementTsang/bottom#1500
[1] rust-lang/rust#127343

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
@ClementTsang ClementTsang mentioned this issue Jul 26, 2024
9 tasks
@ClementTsang
Copy link
Owner

ClementTsang commented Jul 26, 2024

Marking this as closed, published 0.9.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way that is expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants