Remove y/n prompts for save quitting and quitting from the main menu

[Procyonae]

Summary

None

Purpose of change

These prompts don't achieve anything

Describe the solution

Just removes them, leaves the quit without saving (eg on Alt-F4) warning bc losing progress unintentionally as a player would suck

Describe alternatives you've considered

Was originally adding a debug option so contributors could turn all three prompts off

Testing

Additional context

[Brambor]

It is currently here

I would move it here

Because that is where I look for it.

Also, rename to "Query on ..."

[Brambor]

Unfortunately doesn't fix my issue:

1. open crafting GUI
2. EDIT: open the filter in it too
3. alt + F4 OR "cross" to quit
4. Observe: the game still runs
5. close the filter and the crafting GUI
6. The game quits

[Procyonae]

I would move it here

This isn't exactly an annoying feature unless you're a contributor imo which is why I've stuck it in debug options, it does kind of fit with those other "Query on" ones tho so ig I will

Unfortunately doesn't fix my issue

I mean I weren't aiming to fix any imgui window nonsense

[Procyonae]

Wait crafting GUI isn't imgui facepalms
I don't have that issue it shows the prompt and closes normally for me on today's exp

[Brambor]

You are right. It has to be the filter in the crafting GUI. That is not ImGui either AFAIK.

[Procyonae]

Ye idk I think that's probably a string_editor_window but idk why it would delay the prompt until after you close the entire crafting GUI, pretty weird, either way it has nothing to do with this PR though so I suggest you open an issue

[kevingranade]

Instead of an option can you do "really quit? Yes/No/Stop Asking"

[Brambor]

Instead of an option can you do "really quit? Yes/No/Stop Asking"

If this makes it not revertable in options, I disagree.

[Procyonae]

Instead of an option can you do "really quit? Yes/No/Stop Asking"

Why? Then I have to give it it's own save load handling to store it somewhere even if you're Alt-F4ing (also ye you'd have to config edit to revert it which seems dumb)

[Brambor]

On Discord I was recommended SuperF4 (for Windows). Works amazing! Just press ctrl+alt+F4 to SIGKILL (I presume).

[kevingranade]

Why? Then I have to give it it's own save load handling to store it somewhere even if you're Alt-F4ing.

Because were carrying around too many options in the options menu.

[Brambor]

Why? Then I have to give it it's own save load handling to store it somewhere even if you're Alt-F4ing.

Because were carrying around too many options in the options menu.

I think it is nice to have a section of options dedicated to "Query on". If the issue is it is not manageable, make it a separate section. Would that make it manageable?

[db48x]

Every new configuration option we add makes the maintenance and testing burden higher. In principle it doubles it, because you have to test everything with the option turned on and again with it off, though in practice it’s not quite that bad. I would recommend against adding this option at all; either prompt or don’t prompt. Don’t make it configurable.