Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate item contents description in the examine display #78401

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

moxian
Copy link
Contributor

@moxian moxian commented Dec 7, 2024

Summary

Interface "Deduplicate item contents description in the examine display"

Purpose of change

If we have several identical items in our pockets, each individual item is listed separately in the examine display.
This is unwieldly. See:

20241206-234910-cataclysm-tiles
20241206-234914-cataclysm-tiles

Describe the solution

Merge the individual items if they are identical into a single one. This is already how it works for pocket contents, I'm doing the same thing to the item contents now.

Describe alternatives you've considered

N/A

Testing

20241206-234303-cataclysm-tiles

Additional context

This still looks a bit silly with liquid contents (the liquid's description is duplicated), but at least that's not a regression.

20241208-211902

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 7, 2024
@moxian moxian marked this pull request as ready for review December 7, 2024 08:55
@moxian moxian marked this pull request as draft December 7, 2024 10:41
@db48x
Copy link
Contributor

db48x commented Dec 7, 2024

There's very little performance cost to following that pointer, so feel free to combine the code to improve maintainability.

@github-actions github-actions bot added Items: Containers Things that hold other things astyled astyled PR, label is assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Dec 9, 2024
@moxian moxian marked this pull request as ready for review December 9, 2024 05:17
@Night-Pryanik Night-Pryanik reopened this Dec 9, 2024
@Night-Pryanik Night-Pryanik reopened this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. Items: Containers Things that hold other things json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants