Add some tests for NPC rules #78524
Open
Add some tests for NPC rules #78524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
RenechCDDA
force-pushed
the
npc_behavior_tests
branch
from
93baa18 to
4da6ec7
Compare
github-actions
bot
added
the
astyled
RenechCDDA
force-pushed
the
npc_behavior_tests
branch
from
4da6ec7 to
fbb760e
Compare
RenechCDDA
force-pushed
the
npc_behavior_tests
branch
from
fbb760e to
ee873e1
Compare
github-actions
bot
added
the
json-styled
github-actions
bot
removed
the
json-styled
github-actions
bot
added
the
json-styled
RenechCDDA
force-pushed
the
npc_behavior_tests
branch
from
6259843 to
8423110
Compare
RenechCDDA
force-pushed
the
npc_behavior_tests
branch
from
8423110 to
a602354
Compare
|
I've marked this ready to review as it adds three new test cases which cover existing scenarios which need coverage. There are definitely more NPC rules which need test coverage, and I hope to add other tests for them, but I don't want to leave this in draft forever. Better to get the working ones merged and add more as we can |
RenechCDDA
force-pushed
the
npc_behavior_tests
branch
2 times, most recently
from
53f8a4e to
5caefb3
Compare
(sting id naming) (string id *sorting*) (test names don't include special chars)
RenechCDDA
force-pushed
the
npc_behavior_tests
branch
from
5caefb3 to
5cb038b
Compare
+ Clean up some UB + Remove now misleading comment
github-actions
bot
added
the
BasicBuildPassed
RenechCDDA
force-pushed
the
npc_behavior_tests
branch
from
462eae9 to
70c0c8f
Compare
github-actions
bot
removed
the
BasicBuildPassed
RenechCDDA
force-pushed
the
npc_behavior_tests
branch
from
70c0c8f to
e44cdeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
NPC test coverage is lacking...
Describe the solution
Expand it.
Describe alternatives you've considered
Testing
This is the test.
Additional context
The lock doors rule test only tests vehicle doors because the rule does not consider terrain doors. This is pre-existing behavior.
Although it spends some time setting up actual terrain to check this, I've commented out the check that verifies the behavior is correct, as it will currently fail.