Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check transforming items for consistency wrt cables #78556

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

moxian
Copy link
Contributor

@moxian moxian commented Dec 14, 2024

Summary

None

Purpose of change

Check that transformed-into items have plug_in action when the transformed-from item does, and complain if that's not the case.

Prevents #78535-like issues from reoccuring

Describe the solution

Add the aforementioned check to iuse_transform::finalize

Describe alternatives you've considered

Make transform logic smarter and do (handwave) something meaningful when a plugged-in item transforms into unpluggable one. But i don't have a use case to support, and that's more work so maybe some other day.

Testing

Compiled, loaded game, no errors.
Reverted #78537 loaded game, got error, as explected.
Changed the transform target of a cell phone into "asdfsdfsfda", loaded the game, got a bunch of errors as expected, and no segfaults

Additional context

N/A

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` labels Dec 14, 2024
made with github web editor
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 14, 2024
@Night-Pryanik Night-Pryanik merged commit b0e6458 into CleverRaven:master Dec 14, 2024
19 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants