Fix type-casting allocations in broadcasting #1365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| @@ -301,6 +301,8 @@ Base.Broadcast.broadcasted( | |||
| ::Val{n}, | |||
| ) where {n} = Base.Broadcast.broadcasted(x -> Base.literal_pow(^, x, Val(n)), f) | |||
|
|
|||
| Base.Broadcast.broadcasted(::Type{T}, x::Number) where {T <: Number} = x | |||
There was a problem hiding this comment.
Suggested change
| Base.Broadcast.broadcasted(::Type{T}, x::Number) where {T <: Number} = x | |
| Base.Broadcast.broadcasted(::Type{T}, x::Number) where {T <: Number} = T(x) |
I guess we should actually do this instead
|
We can work around this on the implementation side, without type piracy. Maybe that's a better solution for now, until JuliaLang/julia#50554 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1355 and #1097.
I'm not thrilled that this is basically type piracy, but it does fix the allocations. It's actually a bit surprising to me that a simple definition doesn't exist in Base.
This should fix the GPU moisture issue in ClimaAtmos (among other isbits errors and allocations).