Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Couple the HBModel and SWModel for use in the Split-Explicit Stepper #1268

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Couple the HBModel and SWModel for use in the Split-Explicit Stepper #1268

merged 3 commits into from
Jul 23, 2020

Commits on Jul 23, 2020

  1. Add communication functions between SWModel and HBModel 

    fill out communication functions and add necessary aux variables

don't statecheck aux while adding new aux variables

turn off restart values for now

remove time averaging over fast mode and add flag for reconciliation

add zero initializations

replace .=- with .-=

rebase fix for `test_vertical_integral_model.jl`

convert `tendency_from_slow_to_fast!` to new reshape&broadcast setup

Update `reconcile_from_fast_to_slow!` with new reshape&broadcast method

Update to new functions from CliMA#1280

Co-Authored-By: Jean-Michel Campin <jm-c@users.noreply.github.com>
    @blallen @jm-c
    blallen and jm-c committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    07cb28f View commit details
    Browse the repository at this point in the history

  2. Add traits to modify HBModel and SWModel for coupling 

    drive shallow water model by HB model

add coupling traits, use to replace forcing traits in shallow water
model

move coupling for SWModel to file in SplitExplicit

add coupling to HBModel, get fully coupled model to converge to analytic
solution

Add hydrostatic spindown tests with actual multi-rate happening

remove old integral models

get flow deviation working with new reshape&broadcast setup (on cpu).

Remove stub functions for partial coupling

use Coupling trait for dispatch instead of boolean in
SplitExplicitMethod.

use abbreviated model names

Update to new functions from CliMA#1280

Co-Authored-By: Jean-Michel Campin <jm-c@users.noreply.github.com>
    @blallen @jm-c
    blallen and jm-c committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    a65b521 View commit details
    Browse the repository at this point in the history

  3. Switch to using CentralNumericalFluxFirstOrder for ShallowWaterModel 

    This matches up numerical fluxes for the continuity equation in the
baroclinic and barotropic models

Fix `shallow_boundary_state!` numerical flux signatures.

update reference values for tests
    @blallen
    blallen committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    41658d8 View commit details
    Browse the repository at this point in the history