Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Add --nelems for Ocean config #1960

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Add --nelems for Ocean config #1960

merged 2 commits into from
Jan 30, 2021

Conversation

valeriabarra
Copy link
Member

This is a quick patch of PR #1946 to add the --nelems CL option also for the Ocean configuration.

While at it, I also printed the same @info that is printed in the other configs and added a missing config to the doc summary at the top of the file.

I tested this with

$ julia --project test/Ocean/HydrostaticBoussinesq/test_3D_spindown.jl --nelems 4,4,7

and the relevant output is:

┌ Info: Establishing Ocean configuration for hydrostatic_spindown
│     precision               = Float64
│     horiz polynomial order  = 4
│     vert polynomial order   = 4
│     Nˣ # elems              = 4
│     Nʸ # elems              = 4
│     Nᶻ # elems              = 7
│     domain depth            = -4.00e+02 m
└     MPI ranks               = 1
  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

This was referenced Jan 27, 2021
Merged
Merged
@valeriabarra valeriabarra added enhancement New feature or request User Interface labels Jan 27, 2021
@valeriabarra
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 28, 2021
@bors
Try #1960:
355268b
@bors
Copy link
Contributor

bors bot commented Jan 28, 2021

try

Build failed:

kpamnany
kpamnany approved these changes Jan 28, 2021
View reviewed changes
src/Driver/Driver.jl Outdated Show resolved Hide resolved
src/Driver/Driver.jl Outdated Show resolved Hide resolved
src/Driver/driver_configs.jl Outdated Show resolved Hide resolved
blallen
blallen approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@blallen blallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for doing this

@valeriabarra
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 28, 2021
@bors
Try #1960:
56920f8
@valeriabarra
Copy link
Member Author

bors try

@bors
Copy link
Contributor

bors bot commented Jan 28, 2021

try

Already running a review

@bors
Copy link
Contributor

bors bot commented Jan 28, 2021

try

Build failed:

@valeriabarra
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 28, 2021
@bors
Try #1960:
2b0760a
@valeriabarra
Copy link
Member Author

bors try

@bors
Copy link
Contributor

bors bot commented Jan 29, 2021

try

Already running a review

@bors
Copy link
Contributor

bors bot commented Jan 29, 2021

try

Build succeeded:

@valeriabarra
Copy link
Member Author

bors r+

@bors bors bot merged commit 496f43e into master Jan 30, 2021
@bors
Copy link
Contributor

bors bot commented Jan 30, 2021

Build succeeded:

@bors bors bot deleted the valeria/elem-cl-option-ocean branch January 30, 2021 01:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blallen blallen blallen approved these changes

@kpamnany kpamnany kpamnany approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valeriabarra @kpamnany @blallen