Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update three layer simulations to use WENO(order=9) and no SGS scheme #142

Merged
merged 12 commits into from
Nov 9, 2024

Conversation

glwagner
Copy link
Member

No description provided.

@glwagner glwagner requested a review from xkykai March 31, 2024 22:39
snapshot_time_interval = 1minute
passive_tracers = false
data_directory = "/nobackup/users/glwagner/LESbrary/"
Copy link
Contributor

@navidcy navidcy Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is machine-specific directory appropriate to merge?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, let's not merge yet...

Copy link
Contributor

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

(however there seems to be a directory path that is hardcoded for a particular machine -- it that was intentional then it's fine w me!)

@glwagner glwagner merged commit e805aa1 into main Nov 9, 2024
0 of 2 checks passed
@glwagner glwagner deleted the glw/weno-9 branch November 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants