-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganized docs structure #1838
Conversation
Those changes seem positive to me! I can't find the preview though, any idea where that might be? |
No idea! According to @navidcy it should be at https://clima.github.io/OceananigansDocumentation/previews/PR1838, but it says page not found. |
Also here's a more proper source for that: JuliaDocs/Documenter.jl#1131 (comment) So idk what's wrong here. @navidcy any idea? |
Strange... Let me look into it bit more :) |
(in truth, just trying out to see if preview is pushed this time)
This reverts commit b51e538.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve 👍🏼; just good to see the preview that all renders OK before merging.
Now we have a preview: https://clima.github.io/OceananigansDocumentation/previews/PR1838/ (I don't know why... I didn't really do anything...) |
Looks good to me |
I'm happy with these changes too.
Francis
…________________________________
From: Navid C. Constantinou ***@***.***>
Sent: Thursday, July 8, 2021 10:37:30 PM
To: CliMA/Oceananigans.jl ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [CliMA/Oceananigans.jl] Reorganized docs structure (#1838)
Looks good to me
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#1838 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB63PQKXKILDRISGJGSHYQLTWZOGVANCNFSM5ABR3ZGA>.
|
Weird... Documenter.jl works in mysterious ways |
This is an attempt to make the left menu of the docs feel a bit more intuitive and organized. What I did:
I know this is unprompted (nobody complained about the docs) but I think it's a positive change. Eager to hear opinions.