Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test for implicit free surface with ImmersedBoundary and indexed ReducedFields #2723

Closed
wants to merge 24 commits into from
Closed

Fix test for implicit free surface with ImmersedBoundary and indexed ReducedFields #2723

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f585ef8
update for grid with immersed boundary
navidcy Sep 3, 2022
1638f39
simplify picking a point w non-zero u velocity
navidcy Sep 6, 2022
ece5e79
Update test_implicit_free_surface_solver.jl
navidcy Sep 8, 2022
314858b
check for inactive_cell
navidcy Sep 8, 2022
0128ca2
adds debugging
navidcy Sep 9, 2022
cbada59
merge main
navidcy Sep 14, 2022
0aa674f
cleanup
navidcy Sep 14, 2022
e624b10
changed indices for reduced fields
simone-silvestri Sep 15, 2022
f10b415
fixing set!
simone-silvestri Sep 15, 2022
d31a94f
should be ok now
simone-silvestri Sep 15, 2022
71031f7
introduced OneFieldGridded
simone-silvestri Sep 15, 2022
be8eea7
fixed the mean!
simone-silvestri Sep 15, 2022
5952b4d
some cleaning...
simone-silvestri Sep 15, 2022
e6b064b
fix unitrange construct
navidcy Sep 15, 2022
0398ba3
only boundary conditions to fix
simone-silvestri Sep 15, 2022
da244f4
Merge branch 'ncc/test-for-2710' of github.com:CliMA/Oceananigans.jl …
simone-silvestri Sep 15, 2022
e855183
fixed boundary condition issue
simone-silvestri Sep 15, 2022
00ee7e6
comments...
simone-silvestri Sep 15, 2022
98626e2
fix docstring
navidcy Sep 15, 2022
b5fb600
delete stray space
navidcy Sep 15, 2022
c889495
fix indices
navidcy Sep 15, 2022
1f1cd4d
fixed field_reductions
simone-silvestri Sep 15, 2022
77f4e20
Merge branch 'ncc/test-for-2710' of github.com:CliMA/Oceananigans.jl …
simone-silvestri Sep 15, 2022
f6adf70
fixed abstract operation tests
simone-silvestri Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion test/test_implicit_free_surface_solver.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,18 @@ function set_simple_divergent_velocity!(model)

imid = Int(floor(grid.Nx / 2)) + 1
jmid = Int(floor(grid.Ny / 2)) + 1
CUDA.@allowscalar u[imid, jmid, 1] = 1

k_index = 1

grid isa ImmersedBoundaryGrid && begin
while grid.immersed_boundary.bottom_height[imid, jmid] > grid.underlying_grid.zᵃᵃᶜ[k_index]
k_index += 1
end
end

k_index = k_index + 1 ≤ grid.Nz ? k_index + 1 : k_index
navidcy marked this conversation as resolved.
Show resolved Hide resolved

CUDA.@allowscalar u[imid, jmid, k_index] = 0.1

update_state!(model)

Expand Down