Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOIN with Dictionary #10133

Merged
merged 12 commits into from
Apr 18, 2020
Merged

JOIN with Dictionary #10133

merged 12 commits into from
Apr 18, 2020

Conversation

4ertus2
Copy link
Contributor

@4ertus2 4ertus2 commented Apr 8, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Special HashJoin over StorageDictionary. Allow rewrite dictGet() functions with JOINs. It's not backward incompatible itself but could uncover #8400 on some installations.

Detailed description / Documentation draft:
Special HashJoin over StorageDictionary. Do not generate hash-map. Use dictionary for key lookups instead.

Closes #7688

It also could improve #5722 cause JOIN with StorageJoin was broken by rewriting right table into subselect for predicate push down. Current PR fixes it. It does not rewrite table to subselect if right table supports special JOIN.

@blinkov blinkov added the pr-performance Pull request with some performance improvements label Apr 8, 2020
@blinkov blinkov requested review from abyss7 and tavplubix April 8, 2020 19:11
@4ertus2 4ertus2 changed the title [wip] JOIN with Dictionary JOIN with Dictionary Apr 13, 2020
@blinkov blinkov added the pr-backward-incompatible Pull request with backwards incompatible changes label Apr 13, 2020
@alexey-milovidov
Copy link
Member

@blinkov is a robot (and very primitive one) and he has assigned this task by mistake.

@alexey-milovidov alexey-milovidov merged commit 8cea453 into ClickHouse:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backward-incompatible Pull request with backwards incompatible changes pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOIN with Dictionary (lookup join)
4 participants