-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOIN with Dictionary #10133
Merged
Merged
JOIN with Dictionary #10133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blinkov
added
the
pr-backward-incompatible
Pull request with backwards incompatible changes
label
Apr 13, 2020
@blinkov is a robot (and very primitive one) and he has assigned this task by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backward-incompatible
Pull request with backwards incompatible changes
pr-performance
Pull request with some performance improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Special HashJoin over StorageDictionary. Allow rewrite
dictGet()
functions with JOINs. It's not backward incompatible itself but could uncover #8400 on some installations.Detailed description / Documentation draft:
Special HashJoin over StorageDictionary. Do not generate hash-map. Use dictionary for key lookups instead.
Closes #7688
It also could improve #5722 cause JOIN with StorageJoin was broken by rewriting right table into subselect for predicate push down. Current PR fixes it. It does not rewrite table to subselect if right table supports special JOIN.