Use background thread pool for background buffer flushes #10315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,6 +78,7 @@ struct Settings : public SettingsCollection<Settings> | |||
| M(SettingBool, extremes, false, "Calculate minimums and maximums of the result columns. They can be output in JSON-formats.", IMPORTANT) \ | |||
| M(SettingBool, use_uncompressed_cache, true, "Whether to use the cache of uncompressed blocks.", 0) \ | |||
| M(SettingBool, replace_running_query, false, "Whether the running request should be canceled with the same id as the new one.", 0) \ | |||
| M(SettingUInt64, background_buffer_flush_schedule_pool_size, 16, "Number of threads performing background flush for tables with Buffer engine. Only has meaning at server startup.", 0) \ | |||
There was a problem hiding this comment.
Ok.
Only has meaning at server startup.
I hope we will separate these kind of settings eventually.
There was a problem hiding this comment.
Actually I don't understand why they are here and not in server config (i.e. config.xml)...
alexey-milovidov
approved these changes
Apr 18, 2020
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Apr 22, 2020
Follow-up-for: ClickHouse#10315 Follow-up-for: ClickHouse#10263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Use background thread pool for background buffer flushes (this will allow to avoid occupation threads when there are no insert's)
Refs: #6833 (comment) (does this resolves this issue after other fixes and this one?)
P.S. I placed some code (settings and changes in context) a little bit "non grouped" to avoid conflicts with #10263