Revert "fix replaceRegexpAll bug" + proper fix #32945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
vdimir
approved these changes
Dec 19, 2021
Co-authored-by: Vladimir C <vdimir@clickhouse.com>
vdimir
changed the title
alexey-milovidov
added a commit
that referenced
this pull request
Dec 20, 2021
…802019fdc7cf5844d65c2f331883d3 Cherry pick #32945 to 21.12: Revert "fix replaceRegexpAll bug" + proper fix
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 20, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Dec 20, 2021
Backport #32945 to 21.12: Revert "fix replaceRegexpAll bug" + proper fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30292
The code was incorrect. This closes #32777.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix a regression in
replaceRegexpAllfunction. The function worked incorrectly when matched substring was empty. This closes #32777. This closes #30245.