Made parallel_reading_from_replicas work with localhost replica
#36281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
|
@Mergifyio update |
✅ Branch has been successfully updated |
| checkStackSize(); | ||
|
|
||
| auto query_plan = std::make_unique<QueryPlan>(); | ||
| auto mutable_context = const_pointer_cast<Context>(context); |
There was a problem hiding this comment.
That does not seem to be safe to me.
Note, here inside InterpreterSelectQuery we copy context:
Maybe it would be better to:
- create InterpreterSelectQuery first
- add a method inside InterpreterSelectQuery which setMergeTreeReadTaskCallback
- buildQueryPlan
|
Intergration tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
We create a local interpreter if we want to execute query on localhost replica. But for when executing query on multiple replicas we rely on the fact that a connection exists so replicas can talk to coordinator. It is now improved and localhost replica can talk to coordinator directly in the same process