Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash while the grpc port is conflict #40597

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Fix a crash while the grpc port is conflict #40597

merged 2 commits into from
Aug 30, 2022

Conversation

helifu
Copy link
Contributor

@helifu helifu commented Aug 25, 2022 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The clickhouse server will crash if we add a grpc port which has been occupied to the configuration in runtime

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Aug 25, 2022
@Avogar Avogar self-assigned this Aug 25, 2022
@helifu helifu requested a review from Avogar August 26, 2022 03:45
@Avogar Avogar added the can be tested Allows running workflows for external contributors label Aug 26, 2022
@Avogar Avogar merged commit be81d21 into ClickHouse:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avogar Avogar Awaiting requested review from Avogar

Assignees

@Avogar Avogar

Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helifu @Avogar @robot-ch-test-poll