Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix ODR for Loggers class #41060

Merged
merged 6 commits into from
Sep 16, 2022
Merged

Try to fix ODR for Loggers class #41060

merged 6 commits into from
Sep 16, 2022

Conversation

novikd
Copy link
Member

@novikd novikd commented Sep 6, 2022

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Continuation of #40938. Fix ODR violation for Loggers class.
Fixes #40398, #40937

cc @nicelulu @Lucky-Chang

@robot-ch-test-poll robot-ch-test-poll added the pr-build Pull request with build/testing/packaging improvement label Sep 6, 2022
@novikd
Copy link
Member Author

novikd commented Sep 6, 2022

@nicelulu @Lucky-Chang does it help you?

@Lucky-Chang
Copy link
Contributor

Lucky-Chang commented Sep 8, 2022

@nicelulu @Lucky-Chang does it help you?

I propose not use current way to build mini-clickhouse-keeper.
ZOOKEEPER_LOG vs WITH_TEXT_LOG are in different situations. ZOOKEEPER_LOG compile flag not change the class declare (ZooKeeperImpl.h), so it has no ODR problem.

WITH_TEXT_LOG changes Loggers class declare, so encountered the ODR problem. it put things in a mess.

Maybe we can introduce a lambda function hook to Loggers, it's better to solve the problem

@Lucky-Chang
Copy link
Contributor

@nicelulu @Lucky-Chang does it help you?

this pr not fix the problem

@nicelulu
Copy link
Contributor

nicelulu commented Sep 8, 2022

@nicelulu @Lucky-Chang does it help you?

The problem remains.

@novikd novikd marked this pull request as ready for review September 8, 2022 17:17
@novikd novikd requested a review from alesapin September 8, 2022 17:17
@novikd
Copy link
Member Author

novikd commented Sep 8, 2022

After last changes everything works fine on my mac.

I propose not use current way to build mini-clickhouse-keeper.

@Lucky-Chang keeper build script is okay, it just required to prorogate information, that we don't need text log.

@alesapin
Copy link
Member

Builds ok, no failures.

@novikd
Copy link
Member Author

novikd commented Sep 16, 2022

Stateless tests (release) — fail: 1, passed: 4451, skipped: 1

Unrelated

@novikd novikd merged commit 6e77751 into master Sep 16, 2022
@novikd novikd deleted the fix-odr-vialation branch September 16, 2022 16:47
@novikd novikd mentioned this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault on my mac.
5 participants