FunctionsComparison: optimize the string_vector_constant when empty string constant #41870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-performance
jiebinn
changed the title
jiebinn
changed the title
kitaisreal
added
the
can be tested
Add the fast path in string_vector_constant if the string constant is empty string. If the string size a_size and the string constant size b_size are both 0, they are equal and both empty string. And there is no need to call memequalSmallAllowOverflow15() for string comparison. We have tested the patch on ICX 8380 x 2 server with ClickBench. Query 5, 10, 12, 13, 14, 15, 18, 20, 21, 22, 24, 25, 26, 27, 29, 34 of Clickbench have gained 2%-6% improvement. The overall geomean has gained 1% improvement.
kitaisreal
approved these changes
Sep 29, 2022
|
Tests failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry:
Improve performance when comparing strings and one argument is empty constant string.
Add the fast path in string_vector_constant if the string constant is empty string. If the string size a_size and the string constant size b_size are both 0, they are equal and both empty string. And there is no need to call memequalSmallAllowOverflow15() for string comparison.
We have tested the patch on ICX 8380 x 2 server with ClickBench.
Query 5, 10, 12, 13, 14, 15, 18, 20, 21, 22, 24, 25, 26, 27, 29, 34 of Clickbench have gained 2%-6% improvement. The overall geomean has gained 1% improvement.