Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse-format improvements: support VALUES, comments, max_line_length #58246

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented Dec 27, 2023

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • clickhouse-format improvements:
    • support INSERT queries with VALUES
    • support comments (use --comments to output them)
    • support --max_line_length option to format only long queries in multiline

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@vdimir vdimir added the 🎅 🎁 gift🎄 To make people wonder label Dec 27, 2023
@vdimir vdimir force-pushed the vdimir/util_format_values branch from f56f3d2 to 4311e0b Compare December 27, 2023 13:58
@vdimir vdimir changed the title Better clickhouse-format: support VALUES, comments clickhouse-format improvements: support VALUES, comments, max_line_length Dec 27, 2023
@vdimir vdimir force-pushed the vdimir/util_format_values branch from 4311e0b to c3387ce Compare December 27, 2023 14:01
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-feature Pull request with new product feature label Dec 27, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Dec 27, 2023

This is an automated comment for commit e68fc2d with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@Avogar Avogar self-assigned this Dec 27, 2023
@vdimir vdimir force-pushed the vdimir/util_format_values branch 2 times, most recently from e1654f6 to 84893f5 Compare December 28, 2023 10:09
@vdimir vdimir force-pushed the vdimir/util_format_values branch from 84893f5 to e68fc2d Compare January 8, 2024 12:17
@vdimir vdimir requested a review from Avogar January 8, 2024 17:32
@vdimir
Copy link
Member Author

vdimir commented Jan 9, 2024

Stateless tests (release, s3 storage) [1/2] — fail: 1, passed: 2950, skipped: 31 Details

#58337

Upgrade check (msan) — check_status.tsv doesn't exists Details

Logical error: 'Part 1_7_13_1 intersects next part 1_8_13_1. (not #58482 it is merged in this PR)

@vdimir vdimir merged commit b4bfd01 into master Jan 9, 2024
260 of 266 checks passed
@vdimir vdimir deleted the vdimir/util_format_values branch January 9, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎅 🎁 gift🎄 To make people wonder pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants