-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename dns_cache_max_size to dns_cache_max_entries #60500
Rename dns_cache_max_size to dns_cache_max_entries #60500
Conversation
The CacheBase class here https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/DNSResolver.cpp#L179 takes an optional template argument The default weight function is this So we need to change either the setting (e.g., |
This comment was marked as outdated.
This comment was marked as outdated.
Just curious: why? The purpose of this PR is to increase the DNS cache size (see #60257 (comment)), and not change the relative weight of entries. |
This comment was marked as duplicate.
This comment was marked as duplicate.
3 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
IMHO, |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This is an automated comment for commit 39457cd with description of existing statuses. It's updated for the latest CI running ⏳ Click here to open a full report in a separate page Successful checks
|
5b79b85
to
dd4f95e
Compare
dd4f95e
to
48a4265
Compare
… into feature/increase_dns_cache_size
See #60257 (comment)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Renamed server setting
dns_cache_max_size
todns_cache_max_entries
to reduce ambiguity