Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent aggregate function states in mixed x86-64 / ARM clusters #60610

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

HarryLeeIBM
Copy link
Contributor

@HarryLeeIBM HarryLeeIBM commented Feb 29, 2024

In mixed x86-64 / ARM clusters, aggregate function states can be created differently since ARM sometimes calculates slightly different floating-point results.

This blog contains some related tests for the issue.

The fix is to use compiler flag -ffp-contract=off to make sure ARM floating-point calculation produce the same results as on x86-64.

The functional test 02813_seriesDecomposeSTL.sql (which was disabled on ARM) can be used to test the fix, this PR enables it on ARM.

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed potentially inconsistent aggregate function states in mixed x86-64 / ARM clusters.

@qoega qoega added the can be tested Allows running workflows for external contributors label Mar 1, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Mar 4, 2024
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Mar 4, 2024

This is an automated comment for commit 3a4ef70 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure

@HarryLeeIBM
Copy link
Contributor Author

@rschu1ze, could you or somebody in ClickHouse team review the PR? Thanks!

@rschu1ze rschu1ze self-assigned this Mar 5, 2024
@rschu1ze rschu1ze changed the title Fix inconsistent aggregate function states in hybrid cluster of x86_64 and arm64 Fix inconsistent aggregate function states in mixed x86-64 / ARM clusters Mar 5, 2024
@rschu1ze
Copy link
Member

rschu1ze commented Mar 5, 2024

Thanks for tracking this down. Didn't know about -ffp-contract.

Thoughts:

@rschu1ze
Copy link
Member

rschu1ze commented Mar 5, 2024

Besides that, test results in CI look good.

set (COMPILER_FLAGS "${COMPILER_FLAGS}")

# Disable floating-point expression contraction in order to get consistent floating point calculation results across platforms
set (COMPILER_FLAGS "${COMPILER_FLAGS} -ffp-contract=off")
Copy link
Member

@rschu1ze rschu1ze Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put in a newline after l. 323 to make this visually more pleasing, and I'll be happy :-)

(some performance tests aborted due to infrastructure issues, so fresh runs would be needed anyways)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rschu1ze
Copy link
Member

rschu1ze commented Mar 7, 2024

Performance of queries with functions arrayReduce and arrayReduceInRanges deteriorated. Let's re-run CI and check if the problem persists/

@rschu1ze
Copy link
Member

rschu1ze commented Mar 8, 2024

ClickHouse Integration Tests (tsan) [6/6]:

Performance tests:

ClickHouse AST Fuzzer fail with a generic error. I looked at the server and fuzzer logs, but it is not really clear to me what is going wrong. For sure no sanitizer issue and unrelated.

@rschu1ze rschu1ze merged commit e29090d into ClickHouse:master Mar 8, 2024
223 of 235 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants