Allow relative user_files_path #7632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please also add an integration test? |
tavplubix
requested changes
Nov 26, 2019
| some_data = "\t111.222\nData\t333.444" | ||
|
|
||
| node.exec_in_container(['bash', '-c', 'echo "{}{}" > {}'.format( | ||
| filename, |
There was a problem hiding this comment.
Looks like this test doesn't work:
NameError: global name 'filename' is not defined
Please, merge master into your branch before fixing it (now you can see Integration tests — failed:0, passed:0, error:0, it's because integration tests was broken in master)
hczhcz
force-pushed
the
patch-2
branch
3 times, most recently
from
442028a
to
95b9d8e
Compare
tavplubix
approved these changes
Dec 6, 2019
KochetovNicolai
added
the
pr-improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Allow relative
user_files_path(in the way similar toformat_schema_path)