Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug with double move which corrupt original part #8680

Merged
merged 3 commits into from
Jan 18, 2020
Merged

Fixed a bug with double move which corrupt original part #8680

merged 3 commits into from
Jan 18, 2020

Conversation

excitoon
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):

Fixed a bug with double move which corrupt original part.

@excitoon
Copy link
Contributor Author

This fix shall be cherry-picked everywhere when possible.

@excitoon excitoon mentioned this pull request Jan 16, 2020
@excitoon
Copy link
Contributor Author

See #8422 (comment)

@excitoon
Copy link
Contributor Author

excitoon commented Jan 16, 2020

That may be not a solution yet. Possibly part moved from disk A to disk B then from disk B to disk A erasing existing directory, then DeleteOnDestroy logic removed existing part.

@excitoon
Copy link
Contributor Author

If we don't allow to move part back until DeleteOnDestroy happen then this is a correct solution.

@alesapin alesapin requested review from alesapin and removed request for alexey-milovidov January 16, 2020 08:37
Copy link
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need test with long select and two ALTER MOVE to reproduce the problem. Also comment would be nice.

Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@alexey-milovidov alexey-milovidov merged commit 85f395a into ClickHouse:master Jan 18, 2020
@alesapin alesapin added pr-bugfix Pull request with bugfix, not backported by default v20.1 labels Jan 20, 2020
alesapin pushed a commit that referenced this pull request Jan 20, 2020
Fixed a bug with double move which corrupt original part
alesapin pushed a commit that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants