Set X-ClickHouse-Timezone HTTP response header to the server's timezone #9493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
From now on, HTTP responses will have
X-ClickHouse-Timezone
header set to the same timezone value thatSELECT timezone()
would report.executeQuery()
callbacksset_content_type_and_format
andset_query_id
were combined into oneset_result_details
callback that is expected to accept 4 string arguments: query id, content-type, format, and timezone.Motivation: ODBC driver, when reading data in
ODBCDriver2
format (strings), needs to know theDate
's andDateTime
's exact timezone, to be able to convert dates correctly. Similarly, when reading data inRowBinaryWithNamesAndTypes
format (epoch-based integers), to be able to displayDate
andDateTime
the same way as theclickhouse-client
does by default, ODBC driver needs to convert epoch-based integers to server's timezone.