Update script for backporting. #9685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abyss7
reviewed
Mar 16, 2020
| next_category = True | ||
|
|
||
| if category in Description.MAP_CATEGORY_TO_LABEL: | ||
| self.label_name = Description.MAP_CATEGORY_TO_LABEL[category] | ||
| else: | ||
| if not category: | ||
| print('Cannot find category in pr description') |
There was a problem hiding this comment.
It is printed in message before. like
Trying to auto-label pull-request: 8882
| @@ -10,6 +10,10 @@ class Description: | |||
| 'Performance Improvement': 'pr-performance', | |||
| # 'Backward Incompatible Change': doesn't match anything | |||
| 'Build/Testing/Packaging Improvement': 'pr-build', | |||
| 'Non-significant (changelog entry is not needed)': 'pr-non-significant', | |||
There was a problem hiding this comment.
Maybe reuse pr-other tag? It's shorter.
There was a problem hiding this comment.
I think that tag pr-non-significant is less surprising than pr-other while converting from this description.
| @@ -80,6 +80,8 @@ | |||
|
|
|||
| members = set(github.get_members("ClickHouse", "ClickHouse")) | |||
| def print_responsible(pull_request): | |||
| if "author" not in pull_request or pull_request["author"] is None: | |||
There was a problem hiding this comment.
In which cases this may happen?
There was a problem hiding this comment.
I had a case when there was an exception and pull_request["author"] was None
Traceback (most recent call last):
File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"__main__", mod_spec)
File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/nik-kochetov/dev/ClickHouse/utils/github/__main__.py", line 117, in <module>
print(f'{CROSS_MARK} {bad["number"]}: {bad["url"]} ({print_responsible(bad)})')
File "/home/nik-kochetov/dev/ClickHouse/utils/github/__main__.py", line 83, in print_responsible
if pull_request["author"]["login"] in members:
TypeError: 'NoneType' object is not subscriptable
But I have lost exact pr :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
auto-labelfor backporting script.