Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #7920 to 19.16 [Removed check for using Date or DateTime column from TTL expressions] #9967

Closed
wants to merge 1 commit into from
Closed

Backport #7920 to 19.16 [Removed check for using Date or DateTime column from TTL expressions] #9967

wants to merge 1 commit into from

Conversation

excitoon
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Check for using Date or DateTime column from TTL expressions was removed.

@excitoon excitoon changed the base branch from master to 19.16 March 31, 2020 13:17
@alexey-milovidov
Copy link
Member

After we changed docker image for build, It's also required to port the fix for "Compatibility check".

@alexey-milovidov
Copy link
Member

#9833

@alexey-milovidov
Copy link
Member

Also #9433 can be relevant.

@blinkov blinkov added the pr-improvement Pull request with some product improvements label Apr 1, 2020
@blinkov blinkov assigned alesapin and blinkov and unassigned blinkov Apr 1, 2020
Removed check for using `Date` or `DateTime` column from TTL expressions

(cherry picked from commit 9fe987c)
@alexey-milovidov
Copy link
Member

All builds have failed. It looks like Poco submodule is referring incorrect commit.

@alexey-milovidov
Copy link
Member

There are two reasons why it's better to close this issue:

  1. This is not a bugfix but a new feature. So, it should not be backported.
  2. The lifetime of version 19.16 is over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants