Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpack value of indirect types in array column to support nested structures in interfaced slices/arrays #1350

Merged

Conversation

jmaicher
Copy link
Contributor

@jmaicher jmaicher commented Jul 5, 2024

Summary

Unpack value of indirect types in array column to support nested structures in interfaced slices/arrays

Fixes #1349

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2024

CLA assistant check
All committers have signed the CLA.

@jmaicher jmaicher force-pushed the fix/1349/insert-nested-interfaced-arrs branch 2 times, most recently from 8d67d02 to f6e5fda Compare July 5, 2024 08:05
@jmaicher jmaicher force-pushed the fix/1349/insert-nested-interfaced-arrs branch from f6e5fda to 7e83a79 Compare July 5, 2024 10:27
@jmaicher
Copy link
Contributor Author

jmaicher commented Jul 8, 2024

Can we get this merged since it's approved?

@jkaflik
Copy link
Contributor

jkaflik commented Jul 8, 2024

@jmaicher yes. I was waiting for the test results, and obviously, the weekend came around. Thanks!

@jkaflik jkaflik merged commit fa6697e into ClickHouse:main Jul 8, 2024
10 checks passed
codeboten referenced this pull request in open-telemetry/opentelemetry-collector-contrib Aug 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go)
| `v2.26.0` -> `v2.27.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.26.0/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.26.0/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.27.1`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2271-2024-08-05----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.27.0...v2.27.1)

#### What's Changed

##### Fixes 🐛

- Fix INSERT statement normalization match backtick table name by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1366](https://togithub.com/ClickHouse/clickhouse-go/pull/1366)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.27.0...v2.27.1

###
[`v2.27.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2270-2024-08-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.26.0...v2.27.0)

#### Breaking change notice

v2.25.0 was released with a breaking change in
[https://github.com/ClickHouse/clickhouse-go/pull/1306](https://togithub.com/ClickHouse/clickhouse-go/pull/1306).
Please review your implementation.

#### What's Changed

##### Enhancements 🎉

- Unpack value of indirect types in array column to support nested
structures in interfaced slices/arrays by
[@&#8203;jmaicher](https://togithub.com/jmaicher) in
[https://github.com/ClickHouse/clickhouse-go/pull/1350](https://togithub.com/ClickHouse/clickhouse-go/pull/1350)

##### Fixes 🐛

- Common HTTP insert query normalization by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1341](https://togithub.com/ClickHouse/clickhouse-go/pull/1341)

##### Other Changes 🛠

- Update examples std json by
[@&#8203;xjeway](https://togithub.com/xjeway) in
[https://github.com/ClickHouse/clickhouse-go/pull/1240](https://togithub.com/ClickHouse/clickhouse-go/pull/1240)
- ClickHouse 24.6 by [@&#8203;jkaflik](https://togithub.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1352](https://togithub.com/ClickHouse/clickhouse-go/pull/1352)
- ClickHouse 24.7 release by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1363](https://togithub.com/ClickHouse/clickhouse-go/pull/1363)
- Update CHANGELOG with a breaking change note by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1364](https://togithub.com/ClickHouse/clickhouse-go/pull/1364)

#### New Contributors

- [@&#8203;xjeway](https://togithub.com/xjeway) made their first
contribution in
[https://github.com/ClickHouse/clickhouse-go/pull/1240](https://togithub.com/ClickHouse/clickhouse-go/pull/1240)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.26.0...v2.27.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
f7o referenced this pull request in f7o/opentelemetry-collector-contrib Sep 12, 2024
…-telemetry#34443)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go)
| `v2.26.0` -> `v2.27.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.26.0/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.26.0/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.27.1`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2271-2024-08-05----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.27.0...v2.27.1)

#### What's Changed

##### Fixes 🐛

- Fix INSERT statement normalization match backtick table name by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1366](https://togithub.com/ClickHouse/clickhouse-go/pull/1366)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.27.0...v2.27.1

###
[`v2.27.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2270-2024-08-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.26.0...v2.27.0)

#### Breaking change notice

v2.25.0 was released with a breaking change in
[https://github.com/ClickHouse/clickhouse-go/pull/1306](https://togithub.com/ClickHouse/clickhouse-go/pull/1306).
Please review your implementation.

#### What's Changed

##### Enhancements 🎉

- Unpack value of indirect types in array column to support nested
structures in interfaced slices/arrays by
[@&open-telemetry#8203;jmaicher](https://togithub.com/jmaicher) in
[https://github.com/ClickHouse/clickhouse-go/pull/1350](https://togithub.com/ClickHouse/clickhouse-go/pull/1350)

##### Fixes 🐛

- Common HTTP insert query normalization by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1341](https://togithub.com/ClickHouse/clickhouse-go/pull/1341)

##### Other Changes 🛠

- Update examples std json by
[@&open-telemetry#8203;xjeway](https://togithub.com/xjeway) in
[https://github.com/ClickHouse/clickhouse-go/pull/1240](https://togithub.com/ClickHouse/clickhouse-go/pull/1240)
- ClickHouse 24.6 by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1352](https://togithub.com/ClickHouse/clickhouse-go/pull/1352)
- ClickHouse 24.7 release by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1363](https://togithub.com/ClickHouse/clickhouse-go/pull/1363)
- Update CHANGELOG with a breaking change note by
[@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in
[https://github.com/ClickHouse/clickhouse-go/pull/1364](https://togithub.com/ClickHouse/clickhouse-go/pull/1364)

#### New Contributors

- [@&open-telemetry#8203;xjeway](https://togithub.com/xjeway) made their first
contribution in
[https://github.com/ClickHouse/clickhouse-go/pull/1240](https://togithub.com/ClickHouse/clickhouse-go/pull/1240)

**Full Changelog**:
ClickHouse/clickhouse-go@v2.26.0...v2.27.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch insert into columns of type Array(Array..)) fails for interfaced slices
3 participants