Added HTTPS support (bis) #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added 'tls' as default feature * Added 'hyper-tls' as dependency for tls feature * Now when setting up the client, if compiled with 'tls' feature, the 'with_url' method checks for urls that start with 'https:' and creates an HttpsConnector for the hyper client
Closed
loyd
requested changes
Jan 3, 2023
| @@ -101,6 +104,16 @@ impl Client { | |||
| /// ``` | |||
| pub fn with_url(mut self, url: impl Into<String>) -> Self { | |||
| self.url = url.into(); | |||
|
|
|||
| #[cfg(feature = "tls")] | |||
| if self.url.starts_with("https:") { | |||
There was a problem hiding this comment.
From hyper-tls docs:
By default this connector will use plain HTTP if the URL provided uses the HTTP scheme (eg: http://example.com/).
Thus, it seems possible to just use HttpsConnector instead HttpConnector inside impl Default for Client if the feature is enabled.
|
I decided to merge it and fix comments on my own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took most of the code from #36 and wrapped it as suggested. Any reviews are welcome.
Client::with_urlmethod checks for urls that start with 'https:' and creates anHttpsConnectorfor the hyper client