Updated derive to support all serde skip_* attributes #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@loyd just wondering if there's any feedback on this... thanks! |
loyd
reviewed
Oct 5, 2023
derive/src/lib.rs
Outdated
| @@ -3,7 +3,7 @@ use quote::quote; | |||
| use serde_derive_internals::{attr::get_serde_meta_items, Ctxt}; | |||
| use syn::{parse_macro_input, Data, DataStruct, DeriveInput, Fields, Ident, Lit, Meta, NestedMeta}; | |||
|
|
|||
| /// Parses `#[serde(skip_serializing)]` | |||
| /// Parses `#[serde(skip_*)]`; does not work properly with `#[serde(skip_serializing_if)]` | |||
There was a problem hiding this comment.
Let's explicitly allow skip_deserializing to avoid a possible footgun for users.
|
@wspeirs, oh, sorry for an inadequately long answer, and ty for your contribution. LGTM, but let's disable |
It does *not* however support skip_serialization_if
|
OK, made it explicitly |
loyd
added a commit
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue where I wanted a field to be skipped for both inserts and selects, but
#[serde(skip)]wasn't working. This change simply checks the attribute to see if it starts withskip. A bit of a hack as it does not supportskip_serialization_if, but meets my needs, and moves the bar.