feat: support for bool and IN clause
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loyd
commented
Apr 12, 2021
|
|
||
| #[inline] | ||
| fn write(&self, mut dst: impl fmt::Write) -> fmt::Result { | ||
| write!(&mut dst, "[")?; |
There was a problem hiding this comment.
I suppose it's done in order to support empty lists, innit?
JFYI: It's also possible to use tuples here and pass (NULL) for empty lists.
It relies on the property that NULL cannot be checked using equality/IN, so it's safe for Nullable. On the other hand, it's valid syntax, because of the type propagation.
quasiyoke
force-pushed
the
master
branch
4 times, most recently
from
07aa88a
to
7af242a
Compare
loyd
commented
Apr 17, 2021
src/rowbinary/tests.rs
Outdated
| @@ -100,6 +102,8 @@ fn sample_serialized() -> Vec<u8> { | |||
| 0x42, 0x54, 0x43, 0x00, /**/ | |||
| // [Array(Int32)] [-42, 42, -42, 42] | |||
| 0x04, 0xd6, 0x2a, 0xd6, 0x2a, /**/ | |||
| // [Boolean] true | |||
| 0x01, | |||
There was a problem hiding this comment.
Please, add /**/ before the newline to avoid joining by rustfmt when a new field is added
src/sql_builder/mod.rs
Outdated
| #[allow(dead_code)] | ||
| impl<'a, T: Bind> Sealed for &'a [T] {} | ||
|
|
||
| const EMPTY_LIST_SQL: &str = "(NULL)"; |
There was a problem hiding this comment.
Didn't we decide to use arrays instead, as you had suggested?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.