New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any reason not quote the column name? #21

Closed

burmecia opened this issue Nov 5, 2021 · 1 comment

burmecia commented Nov 5, 2021 •

edited

Loading

I think the property name is quoted which is meant to return quoted column name, any reason why not doing that?

https://github.com/silentsokolov/dbt-clickhouse/blob/6f99be054e1a174a347bbb1e8743f44f94d4ae3a/dbt/adapters/clickhouse/column.py#L57

Should it be return f'"{self.column}"'?

The text was updated successfully, but these errors were encountered:

silentsokolov added a commit that referenced this issue


          Use default behavior for a quoted #21

1667cee

Collaborator

silentsokolov commented Nov 5, 2021

Switch to default

silentsokolov closed this as completed

silentsokolov added a commit that referenced this issue


          se default behavior for a quoted #21

202b390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment