Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

would you please add as in /macros/materializations/test.sql #32

Closed
jovezhong opened this issue Jan 9, 2022 · 1 comment
Closed

would you please add as in /macros/materializations/test.sql #32

jovezhong opened this issue Jan 9, 2022 · 1 comment

Comments

@jovezhong
Copy link

https://github.com/silentsokolov/dbt-clickhouse/blob/f1b1b4575c124ccfe46415be8cef699e430f5fca/dbt/include/clickhouse/macros/materializations/test.sql#L11

Sorry being picky. It'll be great if you add the as before dbt_internal_test.

One of our internal tools will review all SQL statements and show warning when the as is missing
silentsokolov added a commit that referenced this issue Jan 10, 2022
@silentsokolov
Fix missing optional "as" #32
63b5433
@jovezhong
Copy link
Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silentsokolov @jovezhong