-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to set sql security option #379
base: main
Are you sure you want to change the base?
Conversation
resolve SQL security and definer logic ClickHouse#359
Mikhail K seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@genzgd Hi. Could you look at my changes quickly please. I have doubt with the following question:
|
@BentsiLeviav @genzgd @3fonov Could you answer questions above? |
DEFINER = {{ definer }} SQL SECURITY DEFINER | ||
{%- elif sql_security == 'invoker' %} | ||
SQL SECURITY INVOKER | ||
{%- elif sql_security == 'none' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we better keep this option unimplemented, as it is deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, I meant the none option, as the documentation indicates the following:
SQL SECURITY NONE is a deprecated option. Any user with the rights to create views with SQL SECURITY NONE will be able to execute any arbitrary query. Thus, it is required to have GRANT ALLOW SQL SECURITY NONE TO in order to create a view with this option.
Hi @dev-mkc19 Per your questions:
|
resolve SQL security and definer logic #359
Summary
Starting from v.24.2 ClickHouse have sql security and definer logic (for view), this changes add ability to use this feature within dbt.
Checklist
Delete items not relevant to your PR: