-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanger feedback #4345
Sanger feedback #4345
Conversation
…o sanger_feedback
…o sanger_feedback
@@ -583,6 +573,43 @@ <h6>No pinned variants</h6> | |||
</div> | |||
{% endmacro %} | |||
|
|||
|
|||
{% macro validation_macro(variant, case) %} | |||
<form action="{{ url_for('cases.mark_validation', institute_id=variant.institute, case_name=case.display_name, variant_id=variant._id) }}" method="POST" accept-charset="utf-8" id="validation_form"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-existing code
</select> | ||
</form> | ||
|
||
<div class="modal fade" tabindex="-1" id="validationModal"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4345 +/- ##
==========================================
+ Coverage 84.71% 84.74% +0.03%
==========================================
Files 310 310
Lines 18522 18550 +28
==========================================
+ Hits 15690 15721 +31
+ Misses 2832 2829 -3 ☔ View full report in Codecov by Sentry. |
# Conflicts: # CHANGELOG.md
# Conflicts: # scout/adapter/mongo/variant_events.py
I haven't touched this PR in a while because I'd like to simplify it a bit. I'll give it a shot today! |
Quality Gate passedIssues Measures |
Closing this as I've opened a simpler one (#4489) |
This PR adds a functionality or fixes a bug.
On case page:
On caseS page:
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stage
and the server iscg-vm1
.ssh <USER.NAME>@cg-vm1.scilifelab.se
sudo -iu hiseq.clinical
ssh localhost
podman ps
systemctl --user stop scout.target
systemctl --user start scout@<this_branch>
systemctl --user status scout.target
scout-stage
) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.se
us; paxa -u <user> -s hasta -r scout-stage
. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browser
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
us; scout --version
paxa
procedure, which will release the allocated resource (scout-stage
) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: