-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnomad keys #4456
Gnomad keys #4456
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4456 +/- ##
==========================================
- Coverage 84.58% 84.57% -0.01%
==========================================
Files 310 310
Lines 18634 18637 +3
==========================================
+ Hits 15762 15763 +1
- Misses 2872 2874 +2 ☔ View full report in Codecov by Sentry. |
I'll leave this like this until we have a good example - I just realised the |
@dnil just assign me if you think this is ready for a review |
Anytime it's not draft, though things may still change with second or third thought. 😉 I made a small refactor to the parser which was just over the CodeFactor complexity threshold, though not the SonarCloud one yet. I also retested it again on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Only a couple of suggestions.
Quality Gate passedIssues Measures |
* Prepare minor version 4.82 * redact CHANGELOG; #4456 was shown on wrong release version * Missing a few lines from Werkzeug unfreeze - changelog and a return value * Improve changelog --------- Co-authored-by: Chiara Rasi <rasi.chiara@gmacil.com> Co-authored-by: Daniel Nilsson <daniel.k.nilsson@gmail.com>
This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stage
and the server iscg-vm1
.ssh <USER.NAME>@cg-vm1.scilifelab.se
sudo -iu hiseq.clinical
ssh localhost
podman ps
systemctl --user stop scout.target
systemctl --user start scout@<this_branch>
systemctl --user status scout.target
scout-stage
) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.se
us; paxa -u <user> -s hasta -r scout-stage
. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browser
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
us; scout --version
paxa
procedure, which will release the allocated resource (scout-stage
) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: