Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnomad keys #4456

Merged
merged 81 commits into from
Apr 30, 2024
Merged

Gnomad keys #4456

merged 81 commits into from
Apr 30, 2024

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Feb 23, 2024

This PR adds a functionality or fixes a bug.

Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. Fist book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout.target
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by
  • tests executed by DN

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (b5a210f) to head (f3864c7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4456      +/-   ##
==========================================
- Coverage   84.58%   84.57%   -0.01%     
==========================================
  Files         310      310              
  Lines       18634    18637       +3     
==========================================
+ Hits        15762    15763       +1     
- Misses       2872     2874       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnil
Copy link
Collaborator Author

dnil commented Feb 23, 2024

I'll leave this like this until we have a good example - I just realised the poorpipe genomes were annotated with 1000g only.

@dnil dnil marked this pull request as ready for review April 29, 2024 16:19
@dnil
Copy link
Collaborator Author

dnil commented Apr 29, 2024

Finally some files passed to annotation again! While perhaps not the finished product, good enough to test this PR:
Screenshot 2024-04-30 at 10 31 04

@northwestwitch
Copy link
Member

@dnil just assign me if you think this is ready for a review

@dnil
Copy link
Collaborator Author

dnil commented Apr 30, 2024

@dnil just assign me if you think this is ready for a review

Anytime it's not draft, though things may still change with second or third thought. 😉 I made a small refactor to the parser which was just over the CodeFactor complexity threshold, though not the SonarCloud one yet. I also retested it again on winningchicken, and it seemed to work ok still.

Copy link
Member

@northwestwitch northwestwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only a couple of suggestions.

scout/parse/variant/frequency.py Outdated Show resolved Hide resolved
scout/parse/variant/transcript.py Outdated Show resolved Hide resolved
scout/parse/variant/transcript.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dnil dnil merged commit 8d83f25 into main Apr 30, 2024
20 checks passed
@dnil dnil deleted the gnomad_keys branch April 30, 2024 16:40
dnil added a commit that referenced this pull request May 14, 2024
* Prepare minor version 4.82

* redact CHANGELOG; #4456 was shown on wrong release version

* Missing a few lines from Werkzeug unfreeze - changelog and a return value

* Improve changelog

---------

Co-authored-by: Chiara Rasi <rasi.chiara@gmacil.com>
Co-authored-by: Daniel Nilsson <daniel.k.nilsson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants