Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.89 #4867

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Version 4.89 #4867

wants to merge 11 commits into from

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Sep 18, 2024

This PR marks a new Scout release. We apply semantic versioning. This is a minor release since it adds new features in a backwards compatible manner.

[4.89]

Added

  • Button on SMN CN page to search variants within SMN1 and SMN2 genes
  • Options for selectively updating OMICS variants (fraser, outrider) on a case
  • Log users' activity to file by specifying USERS_ACTIVITY_LOG_PATH parameter in app config
  • Mean MT coverage, Mean chrom 14 coverage and Estimated mtDNA copy number on MT coverage file from chanjo2 if available
  • Subject id search from caseS page (supporting multiple sample types e.g.) - adding indexes to speed up caseS queries

Changed

  • Documentation for OMICS variants and updating a case
  • Include both creation and deletion dates in gene panels pages
  • Moved code to collect MT copy number stats for the MT report to the chanjo extension
  • On the gene panelS page, show expanded gene panel version list in one column only
  • IGV.js WTS loci default to zoom to a region around a variant instead of whole gene
  • Refactored logging module
  • Case general report no longer shows ORPHA inheritance models. OMIM models are shown colored.
  • Chromosome alias tab files used in the igv.js browser, which now contain the alias for chromosome "M"
  • Enable Gens CN button also for non-wgs cancer track cases

Fixed

  • Broken heading anchors in the documentation (admin-guide/login-system.md and admin-guide/setup-scout.md files)
  • Avoid open login redirect attacks by always redirecting to cases page upon user login
  • Stricter check of ID of gene panels to prevent file downloading vulnerability
  • Removed link to the retired SPANR service. SPIDEX scores are still parsed and displayed if available from variant annotation.
  • Omics variant view test coverage
  • String pattern escape warnings
  • Code creating Alamut links for variant genes without canonical_transcript set
  • Variant delete button in ClinVar submissions page
  • Broken search cases by case similarity
Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. Fist book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout.target
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by
  • tests executed by

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.80%. Comparing base (69b622d) to head (37e880d).

Files with missing lines Patch % Lines
scout/__version__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4867   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         319      319           
  Lines       19314    19314           
=======================================
  Hits        16379    16379           
  Misses       2935     2935           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants